blax-software
/
laravel-websockets
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nitpicks

This commit is contained in:
freek 2018-11-22 00:14:22 +01:00
parent 70de43e050
commit fd534d3d23
2 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/LaravelEcho/Http/Controllers/StatusController.php
View File

@ -6,7 +6,6 @@ use Illuminate\Http\Request;
class StatusController extends EchoController class StatusController extends EchoController
{ {
public function __invoke(Request $request) public function __invoke(Request $request)
{ {
return [ return [

20
src/LaravelEcho/Pusher/Channels/Channel.php
View File

@ -10,7 +10,7 @@ class Channel
/** @var string */ /** @var string */
protected $channelId; protected $channelId;
/** @var ConnectionInterface[] */ /** @var \Ratchet\ConnectionInterface[] */
protected $connections = []; protected $connections = [];
public function __construct(string $channelId) public function __construct(string $channelId)
@ -23,17 +23,13 @@ class Channel
return count($this->connections) > 0; return count($this->connections) > 0;
} }
/** /*
* @link https://pusher.com/docs/pusher_protocol#presence-channel-events * @link https://pusher.com/docs/pusher_protocol#presence-channel-events
*
* @param ConnectionInterface $connection
* @param $payload
*/ */
public function subscribe(ConnectionInterface $connection, $payload) public function subscribe(ConnectionInterface $connection)
{ {
$this->saveConnection($connection); $this->saveConnection($connection);
// Send the success event
$connection->send(json_encode([ $connection->send(json_encode([
'event' => 'pusher_internal:subscription_succeeded', 'event' => 'pusher_internal:subscription_succeeded',
'channel' => $this->channelId 'channel' => $this->channelId
@ -45,9 +41,9 @@ class Channel
unset($this->connections[$connection->socketId]); unset($this->connections[$connection->socketId]);
} }
protected function saveConnection(ConnectionInterface $conn) protected function saveConnection(ConnectionInterface $connection)
{ {
$this->connections[$conn->socketId] = $conn; $this->connections[$connection->socketId] = $connection;
} }
public function broadcast($payload) public function broadcast($payload)
@ -57,10 +53,10 @@ class Channel
} }
} }
public function broadcastToOthers($conn, $payload) public function broadcastToOthers(ConnectionInterface $connection, $payload)
{ {
Collection::make($this->connections)->reject(function ($connection) use ($conn) { Collection::make($this->connections)->reject(function ($connection) use ($connection) {
return $connection->socketId === $conn->socketId; return $connection->socketId === $connection->socketId;
})->each->send(json_encode($payload)); })->each->send(json_encode($payload));
} }
} }