From ad2e5560e388deffc72c57abede71d15f56a1e8a Mon Sep 17 00:00:00 2001 From: freek Date: Mon, 26 Nov 2018 00:29:35 +0100 Subject: [PATCH] nitpicks --- src/ClientProviders/Client.php | 6 +----- src/ClientProviders/ClientProvider.php | 5 +++-- src/ClientProviders/ConfigClientProvider.php | 18 ++++++++++-------- 3 files changed, 14 insertions(+), 15 deletions(-) diff --git a/src/ClientProviders/Client.php b/src/ClientProviders/Client.php index 688a3ef..dc1ef5c 100644 --- a/src/ClientProviders/Client.php +++ b/src/ClientProviders/Client.php @@ -51,8 +51,4 @@ class Client $this->name = $name; } - - - - -} \ No newline at end of file +} diff --git a/src/ClientProviders/ClientProvider.php b/src/ClientProviders/ClientProvider.php index 4f67e0c..4300092 100644 --- a/src/ClientProviders/ClientProvider.php +++ b/src/ClientProviders/ClientProvider.php @@ -5,9 +5,10 @@ namespace BeyondCode\LaravelWebSockets\ClientProviders; interface ClientProvider { + /** @return array[BeyondCode\LaravelWebSockets\ClientProviders\Client] */ + public function all(): array; + public function findByAppId(int $appId): ?Client; public function findByAppKey(string $appKey): ?Client; - - public function all(): array; } \ No newline at end of file diff --git a/src/ClientProviders/ConfigClientProvider.php b/src/ClientProviders/ConfigClientProvider.php index 6a4653e..90241fc 100644 --- a/src/ClientProviders/ConfigClientProvider.php +++ b/src/ClientProviders/ConfigClientProvider.php @@ -6,6 +6,15 @@ use Illuminate\Support\Collection; class ConfigClientProvider implements ClientProvider { + /** @return array[BeyondCode\LaravelWebSockets\ClientProviders\Client] */ + public function all(): array + { + return $this->allClients() + ->map(function ($client) { + return $this->instanciate($client); + }) + ->toArray(); + } public function findByAppId(int $appId): ?Client { $clientAttributes = $this @@ -24,14 +33,7 @@ class ConfigClientProvider implements ClientProvider return $this->instanciate($clientAttributes); } - public function all(): array - { - return $this->allClients() - ->map(function ($client) { - return $this->instanciate($client); - }) - ->toArray(); - } + protected function allClients(): Collection {