disable client messages by default

This commit is contained in:
freek 2018-12-01 16:24:36 +01:00
parent ebd07e6bdb
commit 89ace08139
4 changed files with 21 additions and 20 deletions

View File

@ -17,7 +17,7 @@ return [
'name' => env('APP_NAME'),
'key' => env('PUSHER_APP_KEY'),
'secret' => env('PUSHER_APP_SECRET'),
'enable_client_messages' => true,
'enable_client_messages' => false,
],
],

View File

@ -29,7 +29,7 @@ class ChannelTest extends TestCase
}
/** @test */
public function client_messages_get_broadcasted_to_other_clients_in_the_same_channel()
public function a_client_cannot_broadcast_to_other_clients_by_default()
{
// One connection inside channel "test-channel".
$existingConnection = $this->getConnectedWebSocketConnection(['test-channel']);
@ -40,26 +40,26 @@ class ChannelTest extends TestCase
$this->pusherServer->onMessage($connection, $message);
$existingConnection->assertSentEvent('client-test');
}
/** @test */
public function client_messages_will_not_get_broadcasted_to_other_clients_if_client_messages_are_not_enabled()
{
config()->set('websockets.apps.0.enable_client_messages', false);
// One connection inside channel "test-channel".
$existingConnection = $this->getConnectedWebSocketConnection(['test-channel']);
$connection = $this->getConnectedWebSocketConnection(['test-channel']);
$message = new Message('{"event": "client-test", "data": {}, "channel": "test-channel"}');
$this->pusherServer->onMessage($connection, $message);
$existingConnection->assertNotSentEvent('client-test');
}
/** @test */
public function a_client_can_be_enabled_to_broadcast_to_other_clients()
{
config()->set('websockets.apps.0.enable_client_messages', true);
// One connection inside channel "test-channel".
$existingConnection = $this->getConnectedWebSocketConnection(['test-channel']);
$connection = $this->getConnectedWebSocketConnection(['test-channel']);
$message = new Message('{"event": "client-test", "data": {}, "channel": "test-channel"}');
$this->pusherServer->onMessage($connection, $message);
$existingConnection->assertSentEvent('client-test');
}
/** @test */
public function closed_connections_get_removed_from_all_connected_channels()
{

View File

@ -31,5 +31,6 @@ class ConfigAppProviderTest extends TestCase
$this->assertEquals(1234, $app->id);
$this->assertEquals('TestKey', $app->key);
$this->assertEquals('TestSecret', $app->secret);
$this->assertFalse($app->clientMessagesEnabled);
}
}

View File

@ -40,7 +40,7 @@ abstract class TestCase extends \Orchestra\Testbench\TestCase
'id' => 1234,
'key' => 'TestKey',
'secret' => 'TestSecret',
'enable_client_messages' => true,
'enable_client_messages' => false,
],
]);
}