From 45d951c56b45589c02aa9382f9903ac4a388ad8d Mon Sep 17 00:00:00 2001 From: robindrost Date: Tue, 30 Jun 2020 14:48:28 +0200 Subject: [PATCH 1/6] Update statistics table name check Class name was missing Table, this result into creating new migrations everytime you publish the package. --- src/WebSocketsServiceProvider.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/WebSocketsServiceProvider.php b/src/WebSocketsServiceProvider.php index 02ede2c..3db2939 100644 --- a/src/WebSocketsServiceProvider.php +++ b/src/WebSocketsServiceProvider.php @@ -25,7 +25,7 @@ class WebSocketsServiceProvider extends ServiceProvider __DIR__.'/../config/websockets.php' => base_path('config/websockets.php'), ], 'config'); - if (! class_exists('CreateWebSocketsStatisticsEntries')) { + if (! class_exists('CreateWebSocketsStatisticsEntriesTable')) { $this->publishes([ __DIR__.'/../database/migrations/create_websockets_statistics_entries_table.php.stub' => database_path('migrations/'.date('Y_m_d_His', time()).'_create_websockets_statistics_entries_table.php'), ], 'migrations'); From 8285f6da17ff702f15129f505631c06aac1dc798 Mon Sep 17 00:00:00 2001 From: robindrost Date: Wed, 12 Aug 2020 12:26:07 +0200 Subject: [PATCH 2/6] Update WebSocketsServiceProvider.php Use schema check instead of class name check. --- src/WebSocketsServiceProvider.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/WebSocketsServiceProvider.php b/src/WebSocketsServiceProvider.php index 3db2939..cbc188d 100644 --- a/src/WebSocketsServiceProvider.php +++ b/src/WebSocketsServiceProvider.php @@ -16,6 +16,7 @@ use BeyondCode\LaravelWebSockets\WebSockets\Channels\ChannelManagers\ArrayChanne use Illuminate\Support\Facades\Gate; use Illuminate\Support\Facades\Route; use Illuminate\Support\ServiceProvider; +use Illuminate\Support\Facades\Schema class WebSocketsServiceProvider extends ServiceProvider { @@ -25,7 +26,7 @@ class WebSocketsServiceProvider extends ServiceProvider __DIR__.'/../config/websockets.php' => base_path('config/websockets.php'), ], 'config'); - if (! class_exists('CreateWebSocketsStatisticsEntriesTable')) { + if (!Schema::hasTable('websockets_statistics_entries')) $this->publishes([ __DIR__.'/../database/migrations/create_websockets_statistics_entries_table.php.stub' => database_path('migrations/'.date('Y_m_d_His', time()).'_create_websockets_statistics_entries_table.php'), ], 'migrations'); From c735e70009c3bcdd5a86e7cdbc2176ca089b3ca8 Mon Sep 17 00:00:00 2001 From: robindrost Date: Wed, 12 Aug 2020 12:27:04 +0200 Subject: [PATCH 3/6] Update WebSocketsServiceProvider.php Add missing ;. --- src/WebSocketsServiceProvider.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/WebSocketsServiceProvider.php b/src/WebSocketsServiceProvider.php index cbc188d..f804cd7 100644 --- a/src/WebSocketsServiceProvider.php +++ b/src/WebSocketsServiceProvider.php @@ -16,7 +16,7 @@ use BeyondCode\LaravelWebSockets\WebSockets\Channels\ChannelManagers\ArrayChanne use Illuminate\Support\Facades\Gate; use Illuminate\Support\Facades\Route; use Illuminate\Support\ServiceProvider; -use Illuminate\Support\Facades\Schema +use Illuminate\Support\Facades\Schema; class WebSocketsServiceProvider extends ServiceProvider { From 5b11224865b50c422f14cce07a39d898fc180272 Mon Sep 17 00:00:00 2001 From: robindrost Date: Wed, 12 Aug 2020 12:27:53 +0200 Subject: [PATCH 4/6] Update WebSocketsServiceProvider.php Add missing { --- src/WebSocketsServiceProvider.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/WebSocketsServiceProvider.php b/src/WebSocketsServiceProvider.php index f804cd7..ec0c245 100644 --- a/src/WebSocketsServiceProvider.php +++ b/src/WebSocketsServiceProvider.php @@ -26,7 +26,7 @@ class WebSocketsServiceProvider extends ServiceProvider __DIR__.'/../config/websockets.php' => base_path('config/websockets.php'), ], 'config'); - if (!Schema::hasTable('websockets_statistics_entries')) + if (!Schema::hasTable('websockets_statistics_entries')) { $this->publishes([ __DIR__.'/../database/migrations/create_websockets_statistics_entries_table.php.stub' => database_path('migrations/'.date('Y_m_d_His', time()).'_create_websockets_statistics_entries_table.php'), ], 'migrations'); From dd05008dd24a2c4d5d6af3555385ab0d36b30a73 Mon Sep 17 00:00:00 2001 From: robindrost Date: Wed, 12 Aug 2020 12:28:56 +0200 Subject: [PATCH 5/6] Update WebSocketsServiceProvider.php Namespace import order. --- src/WebSocketsServiceProvider.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/WebSocketsServiceProvider.php b/src/WebSocketsServiceProvider.php index ec0c245..00155d5 100644 --- a/src/WebSocketsServiceProvider.php +++ b/src/WebSocketsServiceProvider.php @@ -15,8 +15,8 @@ use BeyondCode\LaravelWebSockets\WebSockets\Channels\ChannelManager; use BeyondCode\LaravelWebSockets\WebSockets\Channels\ChannelManagers\ArrayChannelManager; use Illuminate\Support\Facades\Gate; use Illuminate\Support\Facades\Route; -use Illuminate\Support\ServiceProvider; use Illuminate\Support\Facades\Schema; +use Illuminate\Support\ServiceProvider; class WebSocketsServiceProvider extends ServiceProvider { From 13d8d9491d03ccde5234070eafeed968b31c0bd1 Mon Sep 17 00:00:00 2001 From: robindrost Date: Wed, 12 Aug 2020 12:29:32 +0200 Subject: [PATCH 6/6] Update WebSocketsServiceProvider.php Add missing space. --- src/WebSocketsServiceProvider.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/WebSocketsServiceProvider.php b/src/WebSocketsServiceProvider.php index 00155d5..a9a7ff9 100644 --- a/src/WebSocketsServiceProvider.php +++ b/src/WebSocketsServiceProvider.php @@ -26,7 +26,7 @@ class WebSocketsServiceProvider extends ServiceProvider __DIR__.'/../config/websockets.php' => base_path('config/websockets.php'), ], 'config'); - if (!Schema::hasTable('websockets_statistics_entries')) { + if (! Schema::hasTable('websockets_statistics_entries')) { $this->publishes([ __DIR__.'/../database/migrations/create_websockets_statistics_entries_table.php.stub' => database_path('migrations/'.date('Y_m_d_His', time()).'_create_websockets_statistics_entries_table.php'), ], 'migrations');