From 4c8a002718ccab535eb7e96f18b6cd043fc35ac3 Mon Sep 17 00:00:00 2001 From: "Fabian @ Blax Software" Date: Sat, 31 Oct 2026 11:05:15 +0100 Subject: [PATCH] fix: sum an offer's reserved merchants in PHP, no raw SQL on the count column Co-Authored-By: Claude Opus 5.5 (1M context) --- app/Engine/Market.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/Engine/Market.php b/app/Engine/Market.php index db4e138..30e3a89 100644 --- a/app/Engine/Market.php +++ b/app/Engine/Market.php @@ -13,7 +13,6 @@ use App\Models\TradeOffer; use App\Models\TradeRoute; use App\Models\Village; use Carbon\CarbonImmutable; -use Illuminate\Support\Facades\DB; /** * The market of one village (architecture.md, "Market"). Merchants under way are @@ -59,7 +58,7 @@ final class Market ->where(fn ($q) => $q->where('origin_id', $id)->where('type', Movement::TRADE)) ->orWhere(fn ($q) => $q->where('target_id', $id)->where('type', Movement::TRADE_RETURN))) ->sum('merchants'); - $reserved = (int) TradeOffer::where('village_id', $id)->sum(DB::raw('count * merchants')); + $reserved = TradeOffer::where('village_id', $id)->get(['count', 'merchants'])->sum(fn (TradeOffer $o) => $o->count * $o->merchants); return $moving + $reserved; }